utopiah/text-code-xr-engine
1
0
Fork 0
Code Issues 83 Pull Requests Projects Releases Wiki Activity

teleporation (on rig) breaks pinching #71

New Issue
Open
opened 2022-12-13 18:38:41 +00:00 by utopiah · 2 comments
utopiah commented 2022-12-13 18:38:41 +00:00
Owner
Copy Link

Consider checking in getClosestTargetElements() if #rig is not at origin anymore then take into account that offset when measure the distance.

See https://github.com/aframevr/aframe/issues/5182

Consider checking in `getClosestTargetElements()` if `#rig` is not at origin anymore then take into account that offset when measure the distance. See https://github.com/aframevr/aframe/issues/5182
utopiah added the bugcore interactions labels 2022-12-13 18:38:46 +00:00
utopiah commented 2023-01-15 18:44:59 +00:00
Author
Owner
Copy Link

Specifically getClosestTargetElement() in pinch related events kind of works :

selectedElement = getClosestTargetElement(
    document.querySelector("#rig").object3D.position.add(event.detail.position )
)

Tested by doing jxr qs #rig sa position 0 0 10 then at that position jxr qs #rig sa position 0 0 0 to go back, which worked, but introduced a vertical offset. Might be related to the adjust-height-in-vr component but probably not as it's only done once entering VR.

Specifically `getClosestTargetElement()` in pinch related events kind of works : ```javascript selectedElement = getClosestTargetElement( document.querySelector("#rig").object3D.position.add(event.detail.position ) ) ``` Tested by doing `jxr qs #rig sa position 0 0 10` then at that position `jxr qs #rig sa position 0 0 0` to go back, which worked, but introduced a vertical offset. Might be related to the `adjust-height-in-vr` component but probably not as it's only done once entering VR.
utopiah commented 2024-08-19 15:52:38 +00:00
Author
Owner
Copy Link

Should be fixed by now, probably with 717ca1aba4 and 1835def7c4

Should be fixed by now, probably with https://git.benetou.fr/utopiah/text-code-xr-engine/commit/717ca1aba43c80c739e285543d28071d4558f5b7 and https://git.benetou.fr/utopiah/text-code-xr-engine/commit/1835def7c451b88aca1508e31c31cdec956276db
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 core interactions
Ways to interact with content that actually makes this scaffolding unique and aligned with its main value of efficient exploration of interfaces.
 demo
focusing on facilitating face to face or remote demonstration
 documentation
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 import/export
Interactions with external content
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug core interactions
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
utopiah
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: utopiah/text-code-xr-engine#71
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?