teleporation (on rig) breaks pinching #71

Open
opened 2 years ago by utopiah · 2 comments
Owner

Consider checking in getClosestTargetElements() if #rig is not at origin anymore then take into account that offset when measure the distance.

See https://github.com/aframevr/aframe/issues/5182

Consider checking in `getClosestTargetElements()` if `#rig` is not at origin anymore then take into account that offset when measure the distance. See https://github.com/aframevr/aframe/issues/5182
utopiah added the
bug
core interactions
labels 2 years ago
Poster
Owner

Specifically getClosestTargetElement() in pinch related events kind of works :

selectedElement = getClosestTargetElement(
    document.querySelector("#rig").object3D.position.add(event.detail.position )
)

Tested by doing jxr qs #rig sa position 0 0 10 then at that position jxr qs #rig sa position 0 0 0 to go back, which worked, but introduced a vertical offset. Might be related to the adjust-height-in-vr component but probably not as it's only done once entering VR.

Specifically `getClosestTargetElement()` in pinch related events kind of works : ```javascript selectedElement = getClosestTargetElement( document.querySelector("#rig").object3D.position.add(event.detail.position ) ) ``` Tested by doing `jxr qs #rig sa position 0 0 10` then at that position `jxr qs #rig sa position 0 0 0` to go back, which worked, but introduced a vertical offset. Might be related to the `adjust-height-in-vr` component but probably not as it's only done once entering VR.
Poster
Owner

Should be fixed by now, probably with 717ca1aba4 and 1835def7c4

Should be fixed by now, probably with https://git.benetou.fr/utopiah/text-code-xr-engine/commit/717ca1aba43c80c739e285543d28071d4558f5b7 and https://git.benetou.fr/utopiah/text-code-xr-engine/commit/1835def7c451b88aca1508e31c31cdec956276db
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: utopiah/text-code-xr-engine#71
Loading…
There is no content yet.