utopiah
/
text-code-xr-engine
1
0
Fork 0
Code Issues 78 Pull Requests Projects Releases Wiki Activity
Labels Milestones
New Issue

Going from AFrame 1.3.0 to 1.4.1 broke rotation on pinch #90

Closed
opened 1 year ago by utopiah · 2 comments
utopiah commented 1 year ago
Owner

In fact was probably already broken by going from 1.3 to 1.4 thus why it's been pinned until now.

Might be related to API change https://github.com/aframevr/aframe/issues/5185

Should check the rotation in the pinchmoved event of the princhprimary component e.g https://git.benetou.fr/utopiah/text-code-xr-engine/src/branch/code-editor/index.html#L1054

PS: also bumps threejs from ^0.137.0 to ^0.147.1

In fact was probably already broken by going from 1.3 to 1.4 thus why it's been pinned until now. Might be related to API change https://github.com/aframevr/aframe/issues/5185 Should check the rotation in the `pinchmoved` event of the `princhprimary` component e.g https://git.benetou.fr/utopiah/text-code-xr-engine/src/branch/code-editor/index.html#L1054 PS: also bumps threejs from ^0.137.0 to ^0.147.1
utopiah commented 1 year ago
Poster
Owner

Fixed via 4cf9c0b148 as indeed the API changed with element.rotation.x becoming element.rotation._x (same for y and z).

Fixed via https://git.benetou.fr/utopiah/text-code-xr-engine/commit/4cf9c0b1485d199c853128ffa75abe92a97c16a1 as indeed the API changed with `element.rotation.x` becoming `element.rotation._x` (same for y and z).
utopiah closed this issue 1 year ago
utopiah commented 1 year ago
Poster
Owner

Actually fixed by 699dbcd6b9 using the proper finger name. Stranger that somehow it did work before few times.

Actually fixed by https://git.benetou.fr/utopiah/text-code-xr-engine/commit/699dbcd6b9f00de4059829d6e24a6e566b12b757 using the proper finger name. Stranger that somehow it did work before few times.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
assymetric-collaboration
avatar-controlled
bind-jxr-target
book
browser-clipboard
chemistry_example
citations
code-editor
code-generation
componentized
componentized-blocks
control-points
core-vs-extras
direct-scaling
draw2d-with-lines
editor-split
emptyview
federation
fosdem-presentation
fossxr
game-mechanics
game-multiple-levels
game-remote-save
game-template-with-asset-validator
gesture-manager
gltf-jxr
graph
hands-controllers-kbd
in-situ-instructions
keyboardless-jxr-editing
knuckle-code-snippets
knuckle-docs
laser-fallback
layer
level-loader
list-editing
mannequin
master
meshing
microgestures
minimalist-template
minimum
mistral-and-graphhopper
motionstick
nodal
ondrop
ontouch
outline-extrude
physics
pinch-to-menu
primitives_as_set
pull-to-value
reader
readibility-background
scaled-linked-editor
screenshot
spatial-introspection
stretch-to-unpack
stt
swagger_example
syntax-highlighting
teleport
textgame
tiles
trail
visibile-scaffolding
visual-tension
warmup
webchuck
webdav
webmidi
webxrsyskbd
Labels
Apply labels
Clear labels
bug
Something is not working core interactions
Ways to interact with content that actually makes this scaffolding unique and aligned with its main value of efficient exploration of interfaces. demo
focusing on facilitating face to face or remote demonstration documentation duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help import/export
Interactions with external content invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug core interactions demo documentation duplicate enhancement help wanted import/export invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: utopiah/text-code-xr-engine#90
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes